Skip to content

Fix ipad dragging issue #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2016
Merged

Fix ipad dragging issue #233

merged 2 commits into from
Sep 1, 2016

Conversation

jooj123
Copy link
Contributor

@jooj123 jooj123 commented Sep 1, 2016

Fixes #232

Before:
before

After:
after

@jooj123 jooj123 mentioned this pull request Sep 1, 2016
Closed
@istarkov
Copy link
Collaborator

istarkov commented Sep 1, 2016

Thank you!
So map somethere in the page will prevent the whole page from moving as usual?
Also this events could be added on the user side? May be just extend help with this solution?

@jooj123
Copy link
Contributor Author

jooj123 commented Sep 1, 2016

I have added this at my end for now - and that works as well.

But it should be in this component because you wont ever need to move the entire page as you drag the map - what would be the purpose of that?

@istarkov
Copy link
Collaborator

istarkov commented Sep 1, 2016

For example we have a page:

<content height={100vh}/>
<content height={100vh}/>
<map/>

Map is on the third screen from top, but prevents the whole page touchmove events,
it's bad when library prevents something in the world to happen.

@jooj123
Copy link
Contributor Author

jooj123 commented Sep 1, 2016 •
edited
Loading

Oh i see what your saying - @istarkov PR is fixed.
As you can see below touchmove still works for stuff outside of map now (the second drag is on the right of the map):

verylatest

@istarkov
Copy link
Collaborator

istarkov commented Sep 1, 2016

Super!!!

@istarkov istarkov merged commit 7d1180c into google-map-react:master Sep 1, 2016
@istarkov
Copy link
Collaborator

istarkov commented Sep 1, 2016

Thank you!
in npm 0.19.0

@catalinfeier catalinfeier mentioned this pull request Oct 21, 2016
Closed
@zeeke zeeke mentioned this pull request Jan 6, 2017
Closed
zeeke added a commit to smesh-team/google-map-react that referenced this pull request Jan 11, 2017
@zeeke
Revert google-map-react#233 fix
40db309
@yoadsn yoadsn mentioned this pull request Mar 9, 2017
Closed
yoadsn added a commit to yoadsn/google-map-react that referenced this pull request Mar 10, 2017
@yoadsn
Revert "Fix ipad dragging issue (google-map-react#233)"
9666ee5 
Using the built in support from google maps would make the component more
mobile friendly.

This reverts commit 7d1180c.
@yoadsn yoadsn mentioned this pull request Mar 10, 2017
Merged
istarkov pushed a commit that referenced this pull request Mar 10, 2017
@yoadsn @istarkov
Stop capturing all touch events and use built in google maps support (#…
956c0ca 
…334)

* Revert "Fix ipad dragging issue (#233)"
Using the built in support from google maps would make the component more
mobile friendly.

This reverts commit 7d1180c.

* Improve documentation around touch device support

* Fix linting errors
@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panning the map with touch devices is very clunky
2 participants
@jooj123 @istarkov