-
Notifications
You must be signed in to change notification settings - Fork 855
Add ne and sw to bounds object #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ne and sw to bounds object #287
Conversation
Hi thank you, fully agree. Will check PR later today or tomorrow. |
All is fine, may be add ability to use NE SW (if NW SE is not provided) to documented fitBounds ? |
@istarkov It's make sense, what do you think about such approach:
|
Super! |
@istarkov cool, i'll push changes tomorrow morning |
Thank you! |
@istarkov hm, I thought a little bit about it today, and i don't really like that we're passing NE and SW to Also i think will can add some helpers like |
Agree that newBounds must have all corners, |
@istarkov done! |
}; | ||
} | ||
|
||
const exports = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we will remove const exports =
and all that this
below, as it was time when export default { blabla }
was the same as export const blabla
Having that it was deprecated in babel there is no need in exports object at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that part seemed strange to me) Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Super, all that my
now will gone ;-) Thank you a lot!!!! |
At npm google-map-react@0.22.0 |
Cool, glad that i helped 😉 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi, thanks for the great library it serving to me faithfully not first time.
I found small problem with bounds object, most geo tools expect to receive data with NE and SW, instead of NW and SE. So i thought it will be cool if bounds object will contain all corners.