fix bug with inferno #291
Closed
fix bug with inferno #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there was a typo there as well. |
istarkov
reviewed
Dec 22, 2016
| @@ -328,10 +328,12 @@ export default class GoogleMap extends Component { | |||
| const mapDom = ReactDOM.findDOMNode(this.refs.google_map_dom); | |||
| window.removeEventListener('resize', this._onWindowResize); | |||
| window.removeEventListener('keydown', this._onKeyDownCapture); | |||
| mapDom.removeEventListener('mousedown', this._onMapMouseDownNative, true); | |||
There was a problem hiding this comment.
Why findDOMNode returns null on Inferno?
There was a problem hiding this comment.
Not sure. Seems like a mistake with inferno. I reported it here: infernojs/inferno#590 . Not sure if/when it will be fixed.
| window.removeEventListener('mouseup', this._onChildMouseUp, false); | ||
| window.removeEventListener('touchmove', this._onTouchMove); | ||
| detectElementResize.addResizeListener(mapDom, that._mapDomResizeCallback); |
|
Ill merge today evening or tomorrow morning, its fun to see that libraries work with inferno preact etc, wanna to play with too |
istarkov
reviewed
Dec 22, 2016
| window.removeEventListener('mouseup', this._onChildMouseUp, false); | ||
| window.removeEventListener('touchmove', this._onTouchMove); | ||
| detectElementResize.addResizeListener(mapDom, that._mapDomResizeCallback); | ||
| if (mapDom) { |
There was a problem hiding this comment.
could u add a comment that this check is for inferno support
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'm trying to migrate from React to InfernoJS. Everything works great, except somehow in
componentWillUnmountthe DOM is already gone (mapDom === null) and this line throws an exception.