Added loose to es2015 for IE10, IE11 support #504
Conversation
your demo app doesn't work on IE9/10 so you will need to make a more simple one to test this fix out. the issue is to do with this.props not being avaiable in constructors for IE9/10 see: babel/babel#3975 it was supposidly fixed 1 year ago but I can't see it working, maybe we need to swap to @babel/core to get this fix? I tried it but the change is made larger due to the curent demo apps build system. Full fix would involve upgading to @babel/core + @babel/preset-env and migrating away from kotatsu in favour of a plain ole react app via webpack (create-react-app maybe?) and then place it into another folder and have that folder habing it's own package.json so we can consume google-map-react as if it were a real library during testing. Sure we would loose hmr, but at this stage hmr isn't all that useful anyway. I'de love the proper fix, but for now I have clients with IE10 browser requirements.
|
fixes #476 |
|
this is the PR in which babel was supposed to fix this, I'm not sure how to verify if babel-core will get these updates if we upgrade it (I ran yarn upgrade but I didn't update the version number so I think the carrot limits us to A.x.x) but it looks like it's a @babel/core fix |
|
@falconmick That is a great input, thanks for that. To be honest I am not sure if we would like to invest that much time taking care about iE 9 and iE10, as they're close to be outdated (hopefully). This ofc if we're talking just about the examples, I believe it is important to be able to support at least iE10, so this PR is 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
IE9 and IE10 require loose to work
your demo app doesn't work on IE9/10 so you will need to make a more simple one to test this fix out. the issue is to do with this.props not being avaiable in constructors for IE9/10 see: babel/babel#3975 it was supposidly fixed 1 year ago but I can't see it working, maybe we need to swap to @babel/core to get this fix? I tried it but the change is made larger due to the curent demo apps build system.
Full fix would involve upgading to @babel/core + @babel/preset-env and migrating away from kotatsu in favour of a plain ole react app via webpack (create-react-app maybe?) and then place it into another folder and have that folder habing it's own package.json so we can consume google-map-react as if it were a real library during testing. Sure we would loose hmr, but at this stage hmr isn't all that useful anyway.
I'de love the proper fix, but for now I have clients with IE10 browser requirements.