Skip to content

Accept 0 as zoom value. #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Accept 0 as zoom value. #525

merged 3 commits into from
Mar 9, 2018

Conversation

itsmichaeldiego
Copy link
Member

@itsmichaeldiego itsmichaeldiego commented Mar 9, 2018

Closes #505

I removed the minZoomOverride option required for overriding the minZoom, I think its pretty clear that if we set a minZoom, we want to override it.

@istarkov please let me know if you set the minZoomOverride for other important reason that I am missing, although I checked the code and it does not seem like it.

@itsmichaeldiego itsmichaeldiego requested a review from istarkov March 9, 2018 01:51
@itsmichaeldiego itsmichaeldiego self-assigned this Mar 9, 2018
@itsmichaeldiego itsmichaeldiego merged commit faf67e5 into master Mar 9, 2018
@itsmichaeldiego itsmichaeldiego deleted the 505-fix-min-zoom-zero branch March 9, 2018 19:08
@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set minZoom to 0
1 participant