Refactor code style #533
Merged
Refactor code style #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmichaeldiego
commented
Mar 11, 2018
| const BASE_URL = 'https://maps'; | ||
| const DEFAULT_URL = `${BASE_URL}.googleapis.com`; | ||
| const API_PATH = '/maps/api/js?callback=_$_google_map_initialize_$_'; |
There was a problem hiding this comment.
Moving this string here, makes https://github.com/istarkov/google-map-react/pull/533/files#diff-4ed1519a6d20f85caa4cc6b843258ecbR86 way clearer.
itsmichaeldiego
commented
Mar 11, 2018
| console.error(message); | ||
| throw new Error(message); | ||
| } | ||
| } | ||
|
|
||
| let queryString = Object.keys(bootstrapURLKeys).reduce( | ||
| let params = Object.keys(bootstrapURLKeys).reduce( |
There was a problem hiding this comment.
The word params makes more sense than queryString, as they're actually params
itsmichaeldiego
commented
Mar 11, 2018
| withContext, | ||
| withProps, | ||
| withPropsOnChange, | ||
| } from 'recompose'; |
There was a problem hiding this comment.
This way of importing things looks clearer
This was referenced Mar 11, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes: