Avoid null error #570
Merged
Avoid null error #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the error "Cannot read property 'removeEventListener' of null"
|
@asundlihardig Could you provide a screenshot showing the error ? |
|
I'm sorry @itsmichaeldiego . The error was reported through Sentry.io |
|
@asundlihardig Sorry I can't merge this without you showing me how this is blocking you or where is the error. There are thousands of places in the code where we could add defensive programming, I need to know why adding it here would make the difference. |
16436be to
f6bb003
Compare
|
@asundlihardig Looking forward to hear back from you! Would like to merge this if its an issue for the users. |
itsmichaeldiego
approved these changes
May 25, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the error "Cannot read property 'removeEventListener' of null"