Add guard around mapDom event listener #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where, even if the end user has a proper google maps API mock, the GoogleMaps component will throw an error when in a test env. ReactDOM.findDOMNode(this.googleMapDom_) returns `null`. This commit wraps the subsequent addEventListener call in an `if` block, ensuring that an empty DOM doesn't add complications to test suites
|
This is great @bignimbus ! Thanks, someone opened a similar PR but provided not as good description as yours. Merging and it will be present in the next release together with other group of changes as this one is not a blocker. Thanks again @bignimbus |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where, even if the end user has a proper google maps API
mock, the GoogleMaps component will throw an error when in a test
env. ReactDOM.findDOMNode(this.googleMapDom_) returns
null.This commit wraps the subsequent addEventListener call in an
ifblock,ensuring that an empty DOM doesn't add complications to test suites
Thank you for your consideration and your hard work on this great library!