Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

chore: release 4.0.2 #741

Merged
merged 3 commits into from
Aug 21, 2019
Merged

chore: release 4.0.2 #741

merged 3 commits into from
Aug 21, 2019

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Aug 15, 2019 •
edited
Loading

🤖 I have created a release *beep* *boop*

4.0.2 (2019-08-21)

Bug Fixes

  • allow calls with no request, add JSON proto (bb1bcc9)
  • warn if maxDataSize=0 (#744) (e322b6c)
  • deps: update @sindresorhus/is to v1 (#747) (dac1102)
  • deps: update dependency acorn to v7 (#748) (ddc3629)
  • deps: use the latest extend (#735) (2d60f49)
  • docs: link to reference docs section on googleapis.dev (#724) (6d809e6)

This PR was generated with Release Please.

@yoshi-automation yoshi-automation added autorelease: pending type: process A process-related concern. May include testing, release, or the like. labels Aug 15, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 15, 2019
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #741 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   85.45%   85.66%   +0.21%     
==========================================
  Files          13       13              
  Lines         949      949              
  Branches      193      193              
==========================================
+ Hits          811      813       +2     
+ Misses         76       75       -1     
+ Partials       62       61       -1
Impacted Files Coverage Δ
src/agent/debuglet.ts 80.69% <0%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041bcd8...0b5f2cf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #741 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   85.45%   85.66%   +0.21%     
==========================================
  Files          13       13              
  Lines         949      949              
  Branches      193      193              
==========================================
+ Hits          811      813       +2     
+ Misses         76       75       -1     
+ Partials       62       61       -1
Impacted Files Coverage Δ
src/agent/debuglet.ts 80.69% <0%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041bcd8...0b5f2cf. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 16, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2671d66). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #741   +/-   ##
=========================================
  Coverage          ?   85.45%           
=========================================
  Files             ?       13           
  Lines             ?      949           
  Branches          ?      193           
=========================================
  Hits              ?      811           
  Misses            ?       76           
  Partials          ?       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2671d66...8ea5f97. Read the comment docs.

@DominicKramer DominicKramer changed the title chore: release 4.0.2 DO NOT LAND: chore: release 4.0.2 Aug 20, 2019
@DominicKramer DominicKramer added the status: blocked Resolving the issue is dependent on other work. label Aug 20, 2019
@DominicKramer
Copy link
Contributor

This is marked as blocked because there are some tests that were manually skipped since they were failing on Node 12. We need to determine whether these tests should be re-enabled before making a release. @kjin What do you suggest?

@kjin
Copy link
Contributor

kjin commented Aug 20, 2019

There are two skipped tests: the circular references test is due to a Node bug and won't get fixed in the near future, so we'll ignore that one. The other one has to do with line-1 breakpoints, which I doubt has real impact on customers (correct me if I'm wrong). I don't see any reason to block this release.

@DominicKramer DominicKramer changed the title DO NOT LAND: chore: release 4.0.2 chore: release 4.0.2 Aug 20, 2019
@DominicKramer DominicKramer removed the status: blocked Resolving the issue is dependent on other work. label Aug 20, 2019
@DominicKramer
Copy link
Contributor

Ok, I've removed the "blocked" label, and this can land after the tests pass.

@DominicKramer DominicKramer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2019
@DominicKramer DominicKramer merged commit 7143525 into master Aug 21, 2019
@yoshi-automation
Copy link
Contributor Author

Release is at https://github.com/googleapis/cloud-debug-nodejs/releases/tag/v4.0.2

@yoshi-automation
Copy link
Contributor Author

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor Author

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DominicKramer DominicKramer DominicKramer approved these changes

Assignees
No one assigned
Labels
autorelease: published cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoshi-automation @DominicKramer @kjin @googlebot @kokoro-team