Skip to content

chore: updating CONTRIBUTING.md #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2024
Merged

chore: updating CONTRIBUTING.md #2434

merged 2 commits into from
Feb 16, 2024

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 16, 2024

Updating CONTRIBUTING.md as per go/java-repos-contrib-guidelines

b/323273913

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@suztomo
chore: updating CONTRIBUTING.md
22e966e 
Updating CONTRIBUTING.md as per go/java-repos-contrib-guidelines

b/323273913
@suztomo suztomo requested a review from a team as a code owner February 16, 2024 17:40
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • CONTRIBUTING.md

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 16, 2024
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Feb 16, 2024
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Feb 16, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: u Pull request is empty. labels Feb 16, 2024
@suztomo suztomo merged commit 7f97bd1 into main Feb 16, 2024
@suztomo suztomo deleted the suztomo-patch-1 branch February 16, 2024 18:24
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 16, 2024
@Adawntoremember
Copy link

7f97bd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suztomo @Adawntoremember @lqiu96