Skip to content

Duplicated bundled discovery documents #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
henribru opened this issue Apr 29, 2021 · 1 comment · Fixed by #1391
Closed

Duplicated bundled discovery documents #1330

henribru opened this issue Apr 29, 2021 · 1 comment · Fixed by #1391
Assignees
@parthea
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@henribru
Copy link

It seems like some of the static discovery documents have ended up being duplicated under ever so slightly different names. One example is https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/discovery_cache/documents/admin.datatransfer_v1.json and https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/discovery_cache/documents/admin.datatransferv1.json. Another is https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/discovery_cache/documents/dfareporting.v3.3.json and https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/discovery_cache/documents/dfareporting.v33.json. There seems to be around 12 of these pairs. Just figured I'd let you know in case it was an accident.
@parthea parthea added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 29, 2021
@parthea
Copy link
Contributor

parthea commented Apr 29, 2021

Thanks for reporting this, @henribru !

@parthea parthea self-assigned this Apr 30, 2021
This was referenced May 27, 2021
Closed
Merged
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 2, 2021
@parthea
fix: delete duplicate discovery artifacts (#1391)
3c40524 
This PR removes duplicated discovery artifacts which are no longer being updated.  I also created symbolic links for the following documents:

`admin.datatransferv1.json` -> `admin.datatransfer_v1.json`
`admin.directoryv1.json` -> `admin.directory_v1.json`
`admin.reportsv1.json` -> `admin.reports_v1.json`

I used the following code to test that the link is working correctly, for `admin.datatransferv1.json` as an example.

```
from googleapiclient.discovery import build
ad = build('admin', 'datatransferv1')
print('Built {}.{}'.format(ad._resourceDesc['name'], ad._resourceDesc['version']))
```

Fixes #1330 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: delete duplicate discovery artifacts googleapis/google-api-python-client
2 participants
@parthea @henribru