Skip to content

[more] remove unused module #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slowy07 opened this issue Jul 13, 2021 · 0 comments · Fixed by #1442
Closed

[more] remove unused module #1441

slowy07 opened this issue Jul 13, 2021 · 0 comments · Fixed by #1442
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@slowy07
Copy link
Contributor

slowy07 commented Jul 13, 2021

problem on google-api-python-client

  • on describe.py contains problem which:
    • unused imported of module from googleapiclient.discovery import UnknownApiNameOrVersion
    • unused imported of module from googleapiclient.errors import HttpError
    • unused imported of module from collections import OrderedDict because collections was imported after that
  • on googleapiclient/schema.py contains problem which:
    • unused imported of module import copy
  • on noxfile.py contains problem which:
    • unused imported of module import sys

steps to fixing the problem

  • removed unused imported of module
  • change code OrderedDict() to ```collections.OrderedDict()``
  • change to one single quoted to double quoted marks for str, if char use single quoted marks
  • reformatted code for get clean and readable code for future maintenance
    Thanks!
@slowy07 slowy07 changed the title [more] remove unused mudle [more] remove unused module Jul 13, 2021
@slowy07 slowy07 mentioned this issue Jul 13, 2021
Merged
4 tasks
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 14, 2021
@parthea parthea added type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. labels Jul 14, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 14, 2021
@slowy07
chore: code clean up (#1442)
d35c912 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-api-python-client/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #1441 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: code clean up slowy07/google-api-python-client
3 participants
@parthea @slowy07 @yoshi-automation