Skip to content

chore: Moving GCE API samples from python-docs-samples (b/191786905) #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 19, 2021
Merged

chore: Moving GCE API samples from python-docs-samples (b/191786905) #1429

merged 9 commits into from
Jul 19, 2021

Conversation

m-strzelczyk
Copy link
Contributor

@m-strzelczyk m-strzelczyk commented Jul 5, 2021 •
edited
Loading

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Code moved from python-docs-samples repo.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 5, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jul 5, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@m-strzelczyk m-strzelczyk marked this pull request as ready for review July 5, 2021 12:36
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner July 5, 2021 12:36
@m-strzelczyk m-strzelczyk requested a review from crwilcox July 5, 2021 12:36
rsamborski
rsamborski reviewed Jul 5, 2021
View reviewed changes
@m-strzelczyk m-strzelczyk marked this pull request as draft July 5, 2021 13:21
@m-strzelczyk
Copy link
Contributor Author

Converting back to draft. Need to move the contents of https://cloud.google.com/compute/docs/tutorials/python-guide to README file, as it will be removed from Cloud Docs page.

@m-strzelczyk m-strzelczyk marked this pull request as ready for review July 5, 2021 16:09
@m-strzelczyk
Copy link
Contributor Author

OK, now we're ready for review :)

parthea
parthea reviewed Jul 13, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations, otherwise LGTM.

parthea
parthea approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one observation, otherwise LGTM.

@parthea parthea requested a review from rsamborski July 19, 2021 12:31
m-strzelczyk and others added 2 commits July 19, 2021 16:11
@m-strzelczyk
chore: Removing incorrect line from README.md
a709c91
@m-strzelczyk @parthea
Update samples/compute/README.md
52d5f0a 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
rsamborski
rsamborski approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-strzelczyk m-strzelczyk merged commit 1961461 into master Jul 19, 2021
@m-strzelczyk m-strzelczyk deleted the compute-samples branch July 19, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsamborski rsamborski rsamborski approved these changes

@parthea parthea parthea approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees

@parthea parthea

@m-strzelczyk m-strzelczyk

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-strzelczyk @rsamborski @parthea