Skip to content

chore: remove unused code #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 13, 2021
Merged

chore: remove unused code #1437

merged 7 commits into from
Jul 13, 2021

Conversation

slowy07
Copy link
Contributor

@slowy07 slowy07 commented Jul 13, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1436 🦕

@slowy07 slowy07 requested a review from a team as a code owner July 13, 2021 02:45
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2021
@parthea parthea changed the title Fixing some chore: remove unused code Jul 13, 2021
parthea
parthea reviewed Jul 13, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR, @slowy07! Just one observation about commented out code. Otherwise, LGTM.

@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2021
slowy07 and others added 4 commits July 13, 2021 17:54
@slowy07 @parthea
Update googleapiclient/discovery.py
d96c118 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@slowy07 @parthea
Update googleapiclient/discovery.py
333840d 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@slowy07
Merge branch 'master' into fixing-some
dfd88e8
@slowy07 @parthea
Update googleapiclient/discovery.py
88ff96a 
suggestion

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2021
parthea
parthea approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @slowy07!

@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge Merge the pull request once unit tests and other checks pass. labels Jul 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 11d78e0 into googleapis:master Jul 13, 2021
@slowy07 slowy07 deleted the fixing-some branch July 13, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fixing issue double imported and unused import of
3 participants
@slowy07 @parthea @yoshi-kokoro