Skip to content

Fix "byteswarning" errors in http and model modules #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

metzen
Copy link
Contributor

@metzen metzen commented Apr 14, 2020

This change fixes a few error prone interactions with str and bytes type objects which surface as exceptions when the googleapiclient library tests are run with the -bb command line flag

See https://docs.python.org/3/using/cmdline.html#cmdoption-b

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2020
This change fixes a few error prone interactions with `str` and `bytes` type
objects which surface as exceptions when the googleapiclient library tests are
run with the "-bb" command line flag

See https://docs.python.org/3/using/cmdline.html#cmdoption-b
@busunkim96 busunkim96 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit ef6420a into googleapis:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants