Skip to content

chore: regens API reference docs #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2020
Merged

chore: regens API reference docs #889

merged 1 commit into from
May 1, 2020

Conversation

danoscarmike
Copy link
Contributor

@danoscarmike danoscarmike commented May 1, 2020 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #775 🦕

Includes a hack in describe.py to ignore a HttpError returned by documentai (requires an API key). It appears that API is under a whitelist?

@danoscarmike danoscarmike added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 1, 2020
@danoscarmike danoscarmike requested a review from busunkim96 May 1, 2020 00:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2020
@danoscarmike danoscarmike removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 1, 2020
@danoscarmike danoscarmike merged commit dd49464 into googleapis:master May 1, 2020
@danoscarmike danoscarmike deleted the docs-regen branch May 1, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for people v1 API create_contact has unused kwarg parent
3 participants
@danoscarmike @busunkim96 @googlebot