Skip to content

test: use self.MOCK_CREDENTIALS in tests #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2020
Merged

test: use self.MOCK_CREDENTIALS in tests #900

merged 3 commits into from
May 14, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented May 13, 2020 •
edited
Loading

Our tests were passing because GOOGLE_APPLICATION_CREDENTIALS are in the environment, but this should technically use mock credentials.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2020
@busunkim96 busunkim96 requested a review from plamut May 13, 2020 20:01
plamut
plamut approved these changes May 14, 2020
View reviewed changes
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing that!

@plamut plamut added the type: cleanup An internal cleanup or hygiene concern. label May 14, 2020
@plamut plamut merged commit 8ed1dcd into master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @plamut @googlebot