Skip to content

fix: fix systest failure #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix: fix systest failure #1703

merged 1 commit into from
Mar 25, 2025

Conversation

sai-sunder-s
Copy link
Contributor

@sai-sunder-s sai-sunder-s commented Mar 25, 2025 •
edited by parthea
Loading

The latest version of nox seems to breaking. We are getting below error even though the env var is indeed being set by the setup script.

nox > Session compute_engine-3.7 raised exception KeyError('GOOGLE_APPLICATION_CREDENTIALS')
Traceback (most recent call last):
  File "/venv/lib/python3.10/site-packages/nox/sessions.py", line 1100, in execute
    self.func(session)
  File "/venv/lib/python3.10/site-packages/nox/_decorators.py", line 94, in __call__
    return self.func(*args, **kwargs)
  File "/tmpfs/src/github/google-auth-library-python/system_tests/noxfile.py", line 276, in compute_engine
    del session.virtualenv.env["GOOGLE_APPLICATION_CREDENTIALS"]
KeyError: 'GOOGLE_APPLICATION_CREDENTIALS'

Ideally each nox session should start with the env var. Maybe a bug in the nox session is not resetting the settings with the start of each session.

BEGIN_COMMIT_OVERRIDE
test: fix systest failure
END_COMMIT_OVERRIDE

@sai-sunder-s sai-sunder-s marked this pull request as ready for review March 25, 2025 19:43
@sai-sunder-s sai-sunder-s requested review from a team as code owners March 25, 2025 19:43
@sai-sunder-s sai-sunder-s enabled auto-merge (squash) March 25, 2025 19:43
@sai-sunder-s sai-sunder-s added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2025
@harkamaljot
Copy link
Contributor

Please update the commit title as fix is repeated multiple times. This is good to unblock the currently failing tests but should we add a tracking somewhere to track this issue so that we can revert back to fetching nox from head, once this issue is fixed by nox?

@sai-sunder-s sai-sunder-s merged commit 55585ff into main Mar 25, 2025
15 checks passed
@sai-sunder-s sai-sunder-s deleted the fixsystest2 branch March 25, 2025 21:14
@release-please release-please bot mentioned this pull request Mar 25, 2025
Closed
@parthea parthea added the release-please:force-run To run release-please label Mar 25, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harkamaljot harkamaljot harkamaljot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai-sunder-s @harkamaljot @parthea