Skip to content

✅ Finalize Identity Pool: Section I9 constants & complete test suite (I1–I9)Finalize/identity pool phase1 #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

cureprotocols
Copy link

This PR completes all scoped sections (I1–I9) of test_identity_pool.py, finalizing Phase 1 of the test suite refactor.

🧩 Finalized:

  • Section I9 constants tagged and scoped for future reuse
  • Cleaned mock values: AUDIENCE, CLIENT_ID, TOKEN_URL, etc.
  • Centralized reusable patterns via make_credentials()

✅ Status:

  • 19/19 tests passing
  • UTF-8 compliant
  • All test logic simulated (no external calls)
  • Fully mock-driven, documented, and structured for contributors

🔒 This suite is now rock-solid, CI-compatible, and upstream-ready.

Ready to begin Phase 2 with:

  • test_pluggable.py refactor
  • Expansion to test_sts.py, test_credentials.py
  • Linting, CI hooks, or packaging

Proudly authored as part of the google-auth-rewired hardening project.

@cureprotocols cureprotocols requested review from a team as code owners April 4, 2025 23:00
Copy link

google-cla bot commented Apr 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cureprotocols cureprotocols force-pushed the finalize/identity-pool-phase1 branch from 6faa16d to 7eb1525 Compare April 5, 2025 16:34
@cureprotocols cureprotocols requested a review from a team as a code owner April 5, 2025 16:34
@cureprotocols cureprotocols requested a review from leahecole April 5, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant