fix compute engine IDTokenCredentials.with_target_audience method #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busunkim96
suggested changes
Aug 7, 2019
setup.py
Outdated
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| setup( | |||
| name='google-auth', | |||
| version='1.6.3', | |||
| version='1.6.4', | |||
There was a problem hiding this comment.
We cut separate release PRs to just bump the version and add changelog notes. See #325 for an example.
There was a problem hiding this comment.
OK, sorry, did not know that. I will revert the version to the one present before.
There was a problem hiding this comment.
I squashed the commits in order to have a single commit with the fix (thus avoiding a commit just for reverting the version back, I do not know if this is compliant with your branch strategy). Let me know if there is other I can do. Thanks!
|
cross referencing with PR that'll remove using the iam signing just to get ID tokens on compute... |
…rget_audience method (googleapis#359)
9e72686 to
a84e427
Compare
busunkim96
approved these changes
Aug 19, 2019
bshaffer
approved these changes
Feb 3, 2020
|
Superceded by #438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody,
Here is the PR for this issue: #359
It should be backward compatible and it should not break anything.
I added an integration test of
IDTokenCredentialsandSignerwhere I usedresponsesfor mocking REST responses, I do not know if that is fine.I followed these guidelines.
Hope everything is ok, if not let me know :)