chore: support string type response.data for gcloud #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busunkim96
approved these changes
May 6, 2020
Ah, sorry I didn't notice your comment. |
|
@arithmetic1728 That's alright! You won't see release-please open a PR (it does patch bumps for If this is urgent you can open a new PR and add the following to the commit body:
|
|
@busunkim96 gcloud has its own google-auth copy in g3, so I just need to update in github and pull it into gcloud. I think I don't need to release it this time. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcloud uses httplib2 for the underlying http where response.data is string instead of bytes.