fix: add SAML challenge to reauth #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuchaoren
reviewed
Jul 30, 2021
liuchaoren
reviewed
Jul 30, 2021
liuchaoren
reviewed
Jul 30, 2021
liuchaoren
reviewed
Jul 30, 2021
liuchaoren
reviewed
Jul 30, 2021
liuchaoren
reviewed
Jul 30, 2021
liuchaoren
approved these changes
Aug 3, 2021
silvolu
suggested changes
Aug 6, 2021
liuchaoren
approved these changes
Aug 12, 2021
liuchaoren
approved these changes
Aug 12, 2021
silvolu
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
(1) re-add SAML challenge to reauth. It throws exception to fail early, and the exception is used by gcloud to instruct the users to do
gcloud auth login. Without it, SAML users have to enter password 5 times then fail.(2) when creating user credential, read
rapt_tokenfield from the json file if exists.(3) disable reauth flow for user credentials and add a new
enable_reauth_refreshflag to user credentials constructor.