chore: omit 'docfx' from docs-presubmit build #831
Conversation
|
Note that I don't actually expect this PR to fix the |
2e958b5 to
f578a99
Compare
| && curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | \ | ||
| apt-key --keyring /usr/share/keyrings/cloud.google.gpg add - \ | ||
| && apt-get update -y \ | ||
| && apt-get install python2 google-cloud-sdk -y |
There was a problem hiding this comment.
do we need python2 if we don't need to run system tests?
There was a problem hiding this comment.
This PR isn't trying to fix #832 (at least not yet). To do that, we need either to have a .kokoro/build-systests.sh script, which runs only the systests, or else work out some environment variable which we use to turn them on / off in .kokoro/build.sh.
Either way will require adding something like .kokoro/presubmit/system-3.8.cfg, to either set the environment variable or trigger the alternate script, which will then need a corresponding tweak to the google3 Kokoro configuration for this repostitory.
There was a problem hiding this comment.
Currently it just skips the system tests (missing 3.7 interpreter), and docs session runs fine. I think it's fine to move forward as-is.
There was a problem hiding this comment.
PR #833 is based on this PR: once we merge here, I will rebase it against master, and then wait to merge until the google3 changes are in place to enable the Kokoro system-3.7 build.
|
Think we're almost there. Blocked by system tests but it'll be fixed soon, docs-presubmit is happy without |
|
@dandhlee Owlbot gets its nose in a twist when the PR is rebased to remove its earlier, unwanted commits. |
|
Hm, I thought rerunning it would resolve itself but I guess not. |
|
@dandhlee I think we need to get a refresh-token PR merged to |
|
|
|
@dandhlee PTAL. |
|
Oops, the Owlbot failure is real: the substitution I added breaks when I run synthool locally. |
Our '.kokoro/build.sh' expects to find the files there, even for the docs build.
Fingers crossed that I have the incantation correct -- I will fix the owlbot replacment once it works.
e43bb29 to
2b5d2c0
Compare
We don't have a 'docfx' session in our noxfile (see #822).
Toward #797.