Skip to content

chore: split systests into separate kokoro build #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2021
Merged

chore: split systests into separate kokoro build #833

merged 3 commits into from
Aug 16, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 13, 2021 •
edited
Loading

Based on the branch from PR #831. I will rebase once that branch lands on master. Done.

Closes #832.

@tseaver tseaver requested a review from dandhlee August 13, 2021 21:24
@tseaver tseaver requested review from arithmetic1728, silvolu and a team as code owners August 13, 2021 21:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2021
dandhlee
dandhlee approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some commits spilled over from #831 but otherwise LGTM. This will need some updates on the internal side.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 13, 2021

@dandhlee Note that the main Kokoro build here succeeds because it no longer runs the systests. Somebody with access to google3 needs to activate the Kokoro system-3.7 build to get that job running here.

@dandhlee
Copy link
Contributor

I can look into it on Monday if that's fine?

@tseaver
Copy link
Contributor Author

tseaver commented Aug 13, 2021

@dandhlee

I can look into it on Monday if that's fine?

Sure, that would be great.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 13, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Aug 13, 2021

Added do not merge label pending the google3 change to activate the Kokoro system-3.7 build.

@tseaver tseaver mentioned this pull request Aug 13, 2021
Merged
@tseaver tseaver force-pushed the 832-split-systests-into-separate-kokoro-build branch from b44d74b to b070ab9 Compare August 13, 2021 22:40
@tseaver
Copy link
Contributor Author

tseaver commented Aug 13, 2021

@dandhlee Once you have the google3 configuration landed on Monday, we can remove the do not merge label, re-run Kokoro to ensure the systests run / pass, and merge.

@dandhlee
Copy link
Contributor

Sounds good!

@dandhlee
Copy link
Contributor

Added the presubmit/system3.7 Kokoro job, will try running it on this commit once it's available.

@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2021
@dandhlee
Copy link
Contributor

confirmed new creation of the Kokoro job and ran it (Successfully!), trying one last time with force-run tag.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2021
@dandhlee
Copy link
Contributor

Confirmed that systest is no longer in presubmit, and is only shown in the separated Kokoro job.

@dandhlee dandhlee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 16, 2021
@dandhlee dandhlee merged commit 5286d6f into master Aug 16, 2021
@dandhlee dandhlee deleted the 832-split-systests-into-separate-kokoro-build branch August 16, 2021 17:16
@tseaver
Copy link
Contributor Author

tseaver commented Aug 16, 2021 •
edited
Loading

Yay! Wait, I don't see the Kokoro - system3.7 job in the list of jobs for the final run??

@tseaver
Copy link
Contributor Author

tseaver commented Aug 16, 2021

@dandhlee PTAL again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

@silvolu silvolu Awaiting requested review from silvolu

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move system tests into a separate Kokoro build
3 participants
@tseaver @dandhlee @yoshi-kokoro