Skip to content

test: address comments for downscoping tests #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2021
Merged

test: address comments for downscoping tests #838

merged 2 commits into from
Aug 16, 2021

Conversation

bojeil-google
Copy link
Contributor

Addresses all comments from:
#837

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2021
@bojeil-google bojeil-google mentioned this pull request Aug 16, 2021
Merged
@bojeil-google
Copy link
Contributor Author

@tseaver FYI

@tseaver tseaver changed the title test: Addresses comments for downscoping tests test: address comments for downscoping tests Aug 16, 2021
@arithmetic1728 arithmetic1728 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 16, 2021
@tseaver tseaver merged commit 93482c6 into googleapis:master Aug 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

@silvolu silvolu Awaiting requested review from silvolu

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bojeil-google @tseaver @arithmetic1728