Skip to content

feat: Improve handling of clock skew #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 7, 2021
Merged

feat: Improve handling of clock skew #858

merged 5 commits into from
Sep 7, 2021

Conversation

eesheesh
Copy link
Contributor

@eesheesh eesheesh commented Sep 7, 2021

  1. Allow up to 60 seconds of clock skew.
  2. Make the error messages actionable to people who don't know the internals of OAuth/JWTs.

@eesheesh eesheesh requested review from arithmetic1728, silvolu and a team as code owners September 7, 2021 20:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2021
@eesheesh eesheesh changed the title Improve handling of clock skew feat: Improve handling of clock skew Sep 7, 2021
@tseaver tseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 7, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2021
@arithmetic1728 arithmetic1728 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2021
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2021
@arithmetic1728 arithmetic1728 merged commit 45c4491 into googleapis:main Sep 7, 2021
@busunkim96 busunkim96 mentioned this pull request Sep 8, 2021
Merged
@taers232c taers232c mentioned this pull request Oct 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvolu silvolu Awaiting requested review from silvolu

2 more reviewers

@tseaver tseaver tseaver approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eesheesh @tseaver @arithmetic1728 @yoshi-kokoro