Skip to content

fix: reduce the clock skew back to 10 seconds #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: reduce the clock skew back to 10 seconds #862

wants to merge 1 commit into from

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Sep 7, 2021 •
edited
Loading

clock skew has to be less than 30 seconds, see #581

if it is longer than 30 seconds, it will cause endless token refresh requests and a CPU spike in client libraries.

@arithmetic1728
fix: reduce the clock skew back to 10 seconds
0247766 
clock skew has to be less than 30 seconds, see #581
@arithmetic1728 arithmetic1728 requested review from silvolu and a team as code owners September 7, 2021 23:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2021
@arithmetic1728 arithmetic1728 mentioned this pull request Sep 7, 2021
Merged
@arithmetic1728
Copy link
Contributor Author

did the fix in #863 instead

@jay0lee jay0lee mentioned this pull request Oct 21, 2021
Closed
@arithmetic1728 arithmetic1728 deleted the arithmetic1728-patch-2 branch May 10, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvolu silvolu Awaiting requested review from silvolu

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arithmetic1728