Skip to content

fix(storage): fix VERSION fixtures in several tests #10091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(storage): fix VERSION fixtures in several tests #10091

wants to merge 1 commit into from

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 10, 2020

Fixes #10090

A recent change to IAM objects in API core started causing an error if accessing those objects as dicts, if their version is > 1. This commit addresses that by setting the VERSION to 1 in fixtures.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the api: storage Issues related to the Cloud Storage API. label Jan 10, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@plamut
fix(storage): adjust VERSION fixtures in tests
49790d0 
A recent change to iam objects in API core started causing an error
if accessing those objects as dicts, if their version is > 1. This
commit addresses that by setting the VERSION to 1 in fixtures.
This was referenced Jan 10, 2020
Merged
Merged
@plamut
Copy link
Contributor Author

plamut commented Jan 10, 2020

The system tests failure (Python 3.6 only) is caused by the rate limit:

429 ... The project exceeded the rate limit for creating and deleting buckets.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2020
@plamut
Copy link
Contributor Author

plamut commented Jan 16, 2020

Not reproducible anymore on master, thus closing.

@plamut plamut closed this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: Fix IAM policy versions in unit test fixtures
3 participants
@plamut @googlebot @yoshi-kokoro