feat(recommender): add v1, set release level to beta #10170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
busunkim96
commented
Jan 17, 2020
- Add v1 and make it the default
- Set release level to beta to reflect the underlying API. https://cloud.google.com/recommender/docs/apis
- Use GAPICBazel rather than Artman
crwilcox
approved these changes
Jan 24, 2020
busunkim96
commented
Jan 24, 2020
| @@ -234,7 +234,7 @@ def list_recommendations( | |||
| ): | |||
| """ | |||
| Lists recommendations for a Cloud project. Requires the | |||
| recommender.\*.list IAM permission for the specified recommender. | |||
| recommender.*.list IAM permission for the specified recommender. | |||
There was a problem hiding this comment.
This looks fine in the generated docs:
This was referenced Jan 29, 2020
Merged
Merged
Merged
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.