feat(bigquery): check rows arg type in insert_rows() #10174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
commented
Jan 20, 2020
| """ | ||
| if not isinstance(rows, (collections_abc.Sequence, collections_abc.Iterator)): | ||
| raise TypeError("rows argument should be a sequence of dicts or tuples") |
There was a problem hiding this comment.
Adding Iterator too as insert_rows_from_dataframe() calls insert_rows() with iterator returned by itertools.islice. dict still will give a False at this statement
tswast
approved these changes
Jan 23, 2020
This was referenced Jan 29, 2020
Merged
Merged
This was referenced Jan 29, 2020
Merged
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #10162
Adding arg type check into
insert_rows()method