Skip to content

chore(recommender): use artman for generation instead of bazel #10356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2020
Merged

chore(recommender): use artman for generation instead of bazel #10356

merged 2 commits into from
Feb 7, 2020

Conversation

busunkim96
Copy link
Contributor

Switches back to Artman as there seems to be something missing in the dependencies with GAPICBazel.

Closes #10346

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2020
@busunkim96 busunkim96 changed the title feat(recommender): regenerate feat(recommender): undeprecate resource name helper methods; change docstring formatting; bump copyright year to 2020 (via synth) Feb 6, 2020
@busunkim96 busunkim96 requested a review from crwilcox February 6, 2020 21:05
@busunkim96 busunkim96 force-pushed the fix-recommender-synth branch from 2213b69 to 14c5033 Compare February 6, 2020 21:09
@busunkim96 busunkim96 changed the title feat(recommender): undeprecate resource name helper methods; change docstring formatting; bump copyright year to 2020 (via synth) feat(recommender): use artman for generation instead of bazel Feb 6, 2020
@busunkim96 busunkim96 changed the title feat(recommender): use artman for generation instead of bazel chore(recommender): use artman for generation instead of bazel Feb 6, 2020
@busunkim96 busunkim96 merged commit e751df7 into googleapis:master Feb 7, 2020
This was referenced Feb 7, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synthesis failed for recommender
3 participants
@busunkim96 @crwilcox @googlebot