Add 'Table.upload_from_file'. #1318

tseaver · 2015-12-22T18:36:19Z

Handles both single-request (multipart) and resumable uploads.

Handles both single-request (multipart) and resumable uploads. Closes #1261

gcloud/bigquery/client.py

@@ -102,20 +102,18 @@ def dataset(self, dataset_name):
        """
        return Dataset(dataset_name, client=self)

-    def _job_from_resource(self, resource):
+    def job_from_resource(self, resource):


gcloud/bigquery/table.py

@@ -693,6 +699,225 @@ def insert_data(self,

        return errors

+    @staticmethod
+    def _configure_job_metadata(metadata,  # pylint: disable=R0913


Addresses: #1318 (comment).

Addresses: #1318 (comment)

Addresses: #1318 (comment).

Addresses: #1318 (comment)

gcloud/bigquery/table.py

+        return client.job_from_resource(json.loads(response_content))
+
+
+def _configure_job_metadata(metadata,  # pylint: disable=R0913


gcloud/bigquery/table.py

+                            quote_character,
+                            skip_leading_rows,
+                            write_disposition):
+    """Helper for :meth:`Table.upload_from_file`."""


dhermes · 2016-01-29T18:38:31Z

@tseaver LGTM to merge so we can get changes into 0.9.0, provided a follow up issue is filed and we get the issues resolved.

tseaver · 2016-01-29T19:02:49Z

Follow up issue: #1431

…_resumable Add 'Table.upload_from_file'.

dhermes · 2016-01-29T19:57:02Z

@tseaver FYI gcloud.bigquery.test_table.TestTable.test_upload_from_file_w_bound_client_multipart fails on Windows.

tseaver added 2 commits December 22, 2015 13:33

Make 'job_from_resource' helper public.

5672636

Add 'Table.upload_from_file'.

5507266

Handles both single-request (multipart) and resumable uploads. Closes #1261

tseaver added the api: bigquery Issues related to the BigQuery API. label Dec 22, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2015

dhermes reviewed Dec 22, 2015
View reviewed changes

tseaver added 2 commits December 22, 2015 13:40

Fix docs for 'Client.list_jobs'.

cf965c4

Add usage docs for 'Table.upload_from_file'.

02eb09d

dhermes reviewed Dec 22, 2015
View reviewed changes

gcloud/bigquery/table.py

@@ -693,6 +699,225 @@ def insert_data(self,

return errors

@staticmethod

def _configure_job_metadata(metadata, # pylint: disable=R0913

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 5 commits January 7, 2016 16:48

Make '_configure_job_metadata' a free function.

4ff36bb

Addresses: #1318 (comment).

Clarify 'temporary URL' comment.

7114005

Addresses: #1318 (comment)

Tuple-ize string format argument.

9adb05d

Addresses: #1318 (comment)

Single-line docstring.

18f24d1

Addresses: #1318 (comment).

Use mnemonic IDs for pylint disable.

7a89de9

Addresses: #1318 (comment)

dhermes reviewed Jan 8, 2016
View reviewed changes

gcloud/bigquery/table.py

quote_character,

skip_leading_rows,

write_disposition):

"""Helper for :meth:`Table.upload_from_file`."""

This comment was marked as spam.

Sign in to view

dhermes mentioned this pull request Jan 29, 2016

Upgrading version to 0.9.0. #1418

Merged

tseaver mentioned this pull request Jan 29, 2016

Clean up / refactor 'Table.upload_from_file' #1431

Closed

tseaver added a commit that referenced this pull request Jan 29, 2016

Merge pull request #1318 from tseaver/1261-add_table_upload_multipart…

2095a06

…_resumable Add 'Table.upload_from_file'.

tseaver merged commit 2095a06 into googleapis:master Jan 29, 2016

tseaver deleted the 1261-add_table_upload_multipart_resumable branch January 29, 2016 19:02

This was referenced Jan 30, 2016

test_upload_from_file_w_bound_client_multipart fails on Windows #1434

Closed

Adding key_filter to datastore Query. #1433

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'Table.upload_from_file'. #1318

Add 'Table.upload_from_file'. #1318

tseaver commented Dec 22, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Jan 29, 2016

tseaver commented Jan 29, 2016

dhermes commented Jan 29, 2016

		return client.job_from_resource(json.loads(response_content))


		def _configure_job_metadata(metadata, # pylint: disable=R0913

Add 'Table.upload_from_file'. #1318

Add 'Table.upload_from_file'. #1318

Conversation

tseaver commented Dec 22, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Jan 29, 2016

tseaver commented Jan 29, 2016

dhermes commented Jan 29, 2016