Adding Bigtable HappyBase Table class. #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding a Table factory to HappyBase connection and adding two NotImplemented methods to the table module (to populate the namespace so that it is the same as the HappyBase implementation).
| raise NotImplementedError('The Cloud Bigtable API output is not the same ' | ||
| 'as the output from the Thrift server, so this ' | ||
| 'helper can not be implemented.', 'Called with', | ||
| cell_map, include_timestamp) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Feb 18, 2016
Adding Bigtable HappyBase Table class.
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding a
Tablefactory to HappyBase connection and adding twoNotImplementedmethods to thetablemodule (to populate the namespace so that it is the same as the HappyBase implementation).