Skip to content

Add exponential backoff for deletion failures. #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2016
Merged

Add exponential backoff for deletion failures. #1683

merged 1 commit into from
Mar 30, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 30, 2016

Fixes: #1657.

Note for potential broader use toward #1619.

@tseaver
Add exponential backoff for deletion failures.
9bd2880 
Fixes: #1657.

Note for potential broader use toward #1619.
@tseaver tseaver added testing api: logging Issues related to the Cloud Logging API. labels Mar 30, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2016
dhermes
dhermes reviewed Mar 30, 2016
View reviewed changes
system_tests/logging_.py
try:
doomed.delete()
break
except NotFound:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 30, 2016

LGTM

@tseaver tseaver merged commit c3d0977 into googleapis:logging-api Mar 30, 2016
@tseaver tseaver deleted the logging-system_tests-retry_deleting_logs branch March 31, 2016 18:25
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot