Skip to content

Add retry for flaky 'topic.exists()' check. #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2016
Merged

Add retry for flaky 'topic.exists()' check. #2214

merged 1 commit into from
Aug 29, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 28, 2016

Toward #2111.

@tseaver tseaver added api: pubsub Issues related to the Pub/Sub API. flaky labels Aug 28, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2016
@daspecster
Copy link
Contributor

LGTM, might as well give it a try?

@tseaver tseaver merged commit e8c064b into googleapis:master Aug 29, 2016
@tseaver tseaver deleted the 2111-pubsub-topic-exists-unavailable branch August 29, 2016 02:05
@tseaver
Copy link
Contributor Author

tseaver commented Aug 29, 2016

Curses, foiled again!

@daspecster
Copy link
Contributor

Isn't that handled in the #2215 PR though?

@tseaver
Copy link
Contributor Author

tseaver commented Aug 29, 2016

@daspecster #2214 is about the test_fetch_delete_subscription_w_deleted_topic failure: this PR is supposed to fix the test_list_subscriptions testcase.

@daspecster
Copy link
Contributor

Oh sorry, my browser started at the bottom line that you linked so I didn't even notice it. Silly chrome.

@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @daspecster @dhermes @googlebot