-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Attempt at making package builds **seem** like "setup.py develop" #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I kind of don't like the idea of this, but if you really feel like you need it then go ahead and merge. |
@jonparrott Here is the problem I am trying to solve:
|
How big is the cost of |
@jonparrott On my old-ish laptop with 16GB RAM the cost is prohibitive (it triples runtime):
The whole point of unit tests is that they can be run during development, and 10s runs are not dev-user-friendly TBH, 3.8s runs are also not dev-user-friendly, especially when the fresh
For comparison, here are the times on this branch:
|
Alrighty. I guess I can live with it until setuptools can get things fixed. |
Thanks for weighing in. FWIW I'm not happy about this hack, but I'm even less happy about the Python ecosystem support for namespace packages. @tseaver Would love to hear what you think |
@dhermes please follow pypa/setuptools#250 and chime in if their solution doesn't seem to fix the issues here. |
@jonparrott @dhermes @tseaver so it looks like this will never be fixed for Python 2.7 or possibly even 3.4.
It seems like not having this PR, or something like it, could be a barrier to contributors. |
@jonparrott Please weigh in here. I am mostly happy with this but unclear on a few sharp corners.
Things I wish were better:
tox.ini
(would be nice to install the deps fromsetup.py
without installing the sourcegoogle-cloud-core
(since we usepkg_resources.get_distribution('google-cloud-core')
for the user agent)__path__
in Python 3 look like it does in Python 2 (unclear why thepep420
bool is in place insetuptools
)