-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Coerce query parameter values from native types to JSON-appropriate types #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tseaver
merged 3 commits into
googleapis:master
from
tseaver:2799-bigquery-query_parms-coerce_values
Dec 4, 2016
Merged
Coerce query parameter values from native types to JSON-appropriate types #2803
tseaver
merged 3 commits into
googleapis:master
from
tseaver:2799-bigquery-query_parms-coerce_values
Dec 4, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes. Also, distingush parsing 'DATETIME' vs. 'TIMESTAMP' properly when processing row data. Closes #2799.
dhermes
approved these changes
Dec 3, 2016
"""Coerce 'value' to a datetime, if set or not nullable.""" | ||
if _not_null(value, field): | ||
# value will be a string, in YYYY-MM-DDTHH:MM:SS form. | ||
return datetime.datetime.strptime(value, '%Y-%m-%dT%H:%M:%S') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Dec 5, 2016
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…arms-coerce_values Coerce query parameter values from native types to JSON-appropriate types
plamut
pushed a commit
to googleapis/python-bigquery
that referenced
this pull request
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the BigQuery API.
cla: yes
This human has signed the Contributor License Agreement.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, distinguish parsing 'DATETIME' vs. 'TIMESTAMP' properly when processing row data.
Closes #2799.