for streaming sample should have "stream=" param #3074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample class can take in content, source_uri or stream, should be stream here.
```
:type content: bytes
:param content: (Optional) Bytes containing audio data.
:type stream: file
:param stream: (Optional) File like object to stream.
```
the type is deduced using:
```sources = [content is not None, source_uri is not None, stream is not None]```
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
I signed it! |
|
CLAs look good, thanks! |
|
LGTM. @daspecster LGTY? |
|
@dhermes, @daspecster my pleasure! |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
for streaming sample should have "stream=" param
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
…oudPlatform/python-docs-samples#3074) Remove Natural Language samples that are no longer included in product documentation. The samples used for documentation are now located in https://github.com/googleapis/python-language/tree/master/samples/v1 and thus have replaced the samples in this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample class can take in content, source_uri or stream, should be stream here.
the type is deduced using:
sources = [content is not None, source_uri is not None, stream is not None]