Skip to content

Vision semi-GAPIC #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Jun 2, 2017
Merged

Vision semi-GAPIC #3373

merged 34 commits into from
Jun 2, 2017

Conversation

lukesneeringer
Copy link
Contributor

This commit removes the entire Vision manual layer and replaces it with a thin wrapper around the GAPIC.

It makes several other changes:

  • The GAPIC and Protos are packaged alongside the library, rather than being separate packages on PyPI. (I plan to move toward this generally, but not all at once.)
  • The docs are updated.
  • The system tests are dramatically thinned down; more should be ported from the old tests before this goes anywhere.

Tagging this "do not merge" for now while other questions about this are worked out.

@lukesneeringer lukesneeringer added api: vision Issues related to the Cloud Vision API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 4, 2017
@lukesneeringer lukesneeringer self-assigned this May 4, 2017
@lukesneeringer lukesneeringer requested a review from theacodes May 4, 2017 20:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2017
theacodes
theacodes reviewed May 4, 2017
View reviewed changes
vision/.coveragerc Outdated
@@ -2,7 +2,7 @@
branch = True

[report]
fail_under = 100
# fail_under = 100

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vision/MANIFEST.in Outdated
@@ -1,4 +1,4 @@
include README.rst LICENSE
include README.rst LICENSE requirements.txt

This comment was marked as spam.

Sign in to view

vision/google/cloud/gapic/__init__.py
@@ -0,0 +1 @@
__import__('pkg_resources').declare_namespace(__name__)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vision/google/cloud/gapic/vision/v1/image_annotator_client.py
_ALL_SCOPES = ('https://www.googleapis.com/auth/cloud-platform', )

def __init__(self,
service_path=SERVICE_ADDRESS,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vision/google/cloud/vision/__init__.py
@@ -1,4 +1,4 @@
# Copyright 2016 Google Inc.
# Copyright 2017, Google Inc. All rights reserved.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vision/google/cloud/vision_v1.py Outdated

from __future__ import absolute_import

from google.cloud.gapic.vision.v1 import image_annotator_client as iac

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vision/google/cloud/vision_v1.py Outdated
from google.cloud.gapic.vision.v1 import enums

from google.cloud.proto.vision.v1 import geometry_pb2 as geometry
from google.cloud.proto.vision.v1 import image_annotator_pb2 as image_annotator

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vision/google/cloud/vision_v1.py Outdated
@add_single_feature_methods
class ImageAnnotatorClient(VisionHelpers, iac.ImageAnnotatorClient):
__doc__ = iac.ImageAnnotatorClient.__doc__
enums = enums

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vision/setup.py Outdated
'zip_safe': False,
'classifiers': [
cur_dir = os.path.realpath(os.path.dirname(__file__))
with io.open('%s/requirements.txt' % cur_dir) as requirements_file:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver reviewed May 17, 2017
View reviewed changes
vision/MANIFEST.in Outdated
@@ -1,4 +1,4 @@
include README.rst LICENSE
include README.rst LICENSE requirements.txt
recursive-include google *.json *.proto

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Jun 7, 2017
Closed
This was referenced Jun 26, 2017
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 26, 2017
This was referenced Jun 26, 2017
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dhermes dhermes mentioned this pull request Jul 26, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer @landrito
Vision semi-GAPIC (googleapis#3373)
62db662
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
Vision semi-GAPIC (googleapis#3373)
31f8326
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
Vision semi-GAPIC (googleapis#3373)
c8f8b9c
atulep pushed a commit that referenced this pull request Apr 3, 2023
@lukesneeringer
Vision semi-GAPIC (#3373)
acd34f6
atulep pushed a commit that referenced this pull request Apr 18, 2023
@lukesneeringer
Vision semi-GAPIC (#3373)
87aa90e
parthea pushed a commit that referenced this pull request Jun 4, 2023
@lukesneeringer
Vision semi-GAPIC (#3373)
0e5c5d4
parthea pushed a commit that referenced this pull request Oct 21, 2023
@lukesneeringer
Vision semi-GAPIC (#3373)
54fb4e0
parthea pushed a commit that referenced this pull request Oct 21, 2023
@lukesneeringer
Vision semi-GAPIC (#3373)
db35d7c
parthea pushed a commit that referenced this pull request Oct 21, 2023
@lukesneeringer
Vision semi-GAPIC (#3373)
00a4c62
parthea pushed a commit that referenced this pull request Oct 22, 2023
@lukesneeringer
Vision semi-GAPIC (#3373)
13462a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@tseaver tseaver tseaver left review comments

@theacodes theacodes theacodes left review comments

@dhermes dhermes dhermes left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@lukesneeringer lukesneeringer

Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukesneeringer @theacodes @tseaver @dhermes @googlebot