Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. #449

tseaver · 2014-12-19T16:19:32Z

Allows selecting EVENTUAL consistency, rather than the STRONG default.

Fixes #305.

Allows selecting EVENTUAL consistency, rather than the STRONG default. Fixes #305.

coveralls · 2014-12-19T16:21:48Z

Coverage remained the same when pulling a41ff58 on tseaver:305-lookup-run_query-eventual into 21e5f45 on GoogleCloudPlatform:master.

gcloud/datastore/connection.py

+        opts = lookup_request.read_options
+        ro_enum = datastore_pb.ReadOptions.ReadConsistency
+        if eventual:
+            opts.read_consistency = ro_enum.Value('EVENTUAL')


@dhermes

Feedback from @dhermes: https://github.com/GoogleCloudPlatform/gcloud-python/pull/449/files#r22115879

@dhermes

Feedback from @dhermes: https://github.com/GoogleCloudPlatform/gcloud-python/pull/449/files#r22116090

@dhermes

Feedback from @dhermes: #449 (comment) #449 (comment)

coveralls · 2014-12-19T17:43:18Z

Coverage remained the same when pulling a2a11bd on tseaver:305-lookup-run_query-eventual into 21e5f45 on GoogleCloudPlatform:master.

tseaver · 2014-12-19T17:46:04Z

@dhermes PTAL: I think I addressed all your concerns.

dhermes · 2014-12-19T18:15:58Z

Code checks out, still need to check the tests.

dhermes · 2014-12-19T20:06:38Z

LGTM

Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'.

Fix regression test failure introduced in PR #449.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…inding's list of attributes (#449) * feat: add cloud_dlp_inspection and cloud_dlp_data_profile fields to finding's list of attributes docs: miscellaneous style improvements PiperOrigin-RevId: 525798516 Source-Link: googleapis/googleapis@36a885f Source-Link: googleapis/googleapis-gen@c47a1b7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQ3YTFiNzk5MjZlYjRiOWZjNDdmNDQ1YTNhODk3MTMxNDA3NWRlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [x] Regenerate this pull request now. PiperOrigin-RevId: 417030293 Source-Link: googleapis/googleapis@ebef8e6 Source-Link: googleapis/googleapis-gen@1395126 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTM5NTEyNjhiMDA5ZDk4ZDgyMzU1Y2NkOTY0N2Y0MzUwNTkwNjA5ZCJ9 feat(v2): added filter in list documentations request feat(v2): added option to import custom metadata from Google Cloud Storage in reload document request feat(v2): added option to apply partial update to the smart messaging allowlist in reload document request feat(v2): added filter in list knowledge bases request

🤖 I have created a release *beep* *boop* --- ## [2.11.0](googleapis/python-dialogflow@v2.10.0...v2.11.0) (2022-01-13) ### Features * support document metadata filter in article suggestion ([#442](googleapis/python-dialogflow#442)) ([6f615f9](googleapis/python-dialogflow@6f615f9)) * **v2:** added export documentation method ([#449](googleapis/python-dialogflow#449)) ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2:** added filter in list documentations request ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2:** added filter in list knowledge bases request ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2:** added option to apply partial update to the smart messaging allowlist in reload document request ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2:** added option to import custom metadata from Google Cloud Storage in reload document request ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2beta1:** add support for knowledge_base in knowledge operation metadata ([0f60629](googleapis/python-dialogflow@0f60629)) * **v2beta1:** added option to configure the number of sentences in the suggestion context ([#453](googleapis/python-dialogflow#453)) ([e48ea00](googleapis/python-dialogflow@e48ea00)) * **v2beta1:** removed OPTIONAL for speech model variant ([#448](googleapis/python-dialogflow#448)) ([0f60629](googleapis/python-dialogflow@0f60629)) * **v2:** removed OPTIONAL for speech model variant ([#447](googleapis/python-dialogflow#447)) ([56efd10](googleapis/python-dialogflow@56efd10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(bazel): update protobuf to v3.21.3 chore(bazel): update gax-java to 2.18.4 PiperOrigin-RevId: 463115700 Source-Link: googleapis/googleapis@52130a9 Source-Link: googleapis/googleapis-gen@6a4d9d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@050953d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Add 'eventual' flag to 'Connection.lookup()'/'Connection.run_query()'.

a41ff58

Allows selecting EVENTUAL consistency, rather than the STRONG default. Fixes #305.

tseaver changed the title ~~Add 'eventual' flag to 'Connection.lookup()'/'Connection.run_query()'.~~ Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. Dec 19, 2014

tseaver added api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Dec 19, 2014

dhermes reviewed Dec 19, 2014
View reviewed changes

gcloud/datastore/connection.py

opts = lookup_request.read_options

ro_enum = datastore_pb.ReadOptions.ReadConsistency

if eventual:

opts.read_consistency = ro_enum.Value('EVENTUAL')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 3 commits December 19, 2014 12:28

Spell enumerated value more naturally.

7ce27d2

Feedback from @dhermes: https://github.com/GoogleCloudPlatform/gcloud-python/pull/449/files#r22115879

Improve variable names.

31ab4ea

Feedback from @dhermes: https://github.com/GoogleCloudPlatform/gcloud-python/pull/449/files#r22116090

DRY out read_options logic.

a2a11bd

Feedback from @dhermes: #449 (comment) #449 (comment)

tseaver added a commit that referenced this pull request Dec 19, 2014

Merge pull request #449 from tseaver/305-lookup-run_query-eventual

5723288

Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'.

tseaver merged commit 5723288 into googleapis:master Dec 19, 2014

tseaver deleted the 305-lookup-run_query-eventual branch December 19, 2014 20:09

tseaver restored the 305-lookup-run_query-eventual branch December 19, 2014 20:51

tseaver deleted the 305-lookup-run_query-eventual branch December 19, 2014 20:51

tseaver added a commit that referenced this pull request Dec 19, 2014

Merge pull request #452 from tseaver/449-fix_transaction_borked_in_449

b343acf

Fix regression test failure introduced in PR #449.

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(deps): update dependency google-cloud-speech to v2.16.0 (#449)

73c8724

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(deps): update dependency google-cloud-speech to v2.16.0 (#449)

e70f7c7

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore(deps): update dependency google-cloud-speech to v2.16.0 (#449)

4da990d

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 2.9.1 (#449)

95aea66

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 3.11.1 (#449)

eafaef4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update all dependencies (#449)

ef8239d

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.11.4 (#449)

f8bf60a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(deps): update dependency google-cloud-speech to v2.16.0 (#449)

b0a47e4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. #449

Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. #449

Uh oh!

tseaver commented Dec 19, 2014

Uh oh!

coveralls commented Dec 19, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Dec 19, 2014

Uh oh!

tseaver commented Dec 19, 2014

Uh oh!

dhermes commented Dec 19, 2014

Uh oh!

dhermes commented Dec 19, 2014

Uh oh!

Uh oh!

Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. #449

Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. #449

Uh oh!

Conversation

tseaver commented Dec 19, 2014

Uh oh!

coveralls commented Dec 19, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Dec 19, 2014

Uh oh!

tseaver commented Dec 19, 2014

Uh oh!

dhermes commented Dec 19, 2014

Uh oh!

dhermes commented Dec 19, 2014

Uh oh!

Uh oh!