Spanner: clean up databases after use #4556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is not correct. We are forced to re-use / share instances across test runs (and for other purposes), which means that we should only ever drop databases which are created in the current test run. |
|
But the way the tests are set up, it doesn't seem like all the tests get cleaned up, especially if I interrupt in the middle?
|
Our cleanup has been tailored to a "graceful" exit (i.e. tests may error, but user doesn't kill process). We could consider a more resilient approach but I don't think it's worth the effort. |
|
Until we go back to using a created-from-scratch instance, we cannot drop all databases, because the CI may be running more than one job at once in the same instance. There may also be other databases pre-populated (e.g., to run the "large chunk" tests) which should never be dropped. |
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
…loudPlatform/python-docs-samples#4556) Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.