Skip to content

Allow get() to take a single key (in addition to a list) #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2015
Merged

Allow get() to take a single key (in addition to a list) #521

merged 1 commit into from
Jan 8, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 8, 2015

Has #520 as diffbase.

@dhermes dhermes mentioned this pull request Jan 8, 2015
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 923302a on dhermes:allow-get-single-key into 77cfe10 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Jan 8, 2015

I've avoided collections.Iterable in the past, because it matches str / unicode. Maybe we don't care about that here.

@tseaver
Copy link
Contributor

tseaver commented Jan 8, 2015

Other than that, LGTM

@dhermes dhermes force-pushed the allow-get-single-key branch from 923302a to 184cfb9 Compare January 8, 2015 23:06
@dhermes
Copy link
Contributor Author

dhermes commented Jan 8, 2015

My take is that if the iterable does not contain Keys then it will fail at the point of keys[0].dataset_id.

For example I accidentally left [key] in Test_get_function._miss_helper

        if use_list:
            key = [key]
        results = self._callFUT([key], connection=connection)

and got an error like

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'list' object has no attribute 'dataset_id'

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 184cfb9 on dhermes:allow-get-single-key into * on GoogleCloudPlatform:master*.

dhermes added a commit that referenced this pull request Jan 8, 2015
@dhermes
Merge pull request #521 from dhermes/allow-get-single-key
12c6afd 
Allow get() to take a single key (in addition to a list)
@dhermes dhermes merged commit 12c6afd into googleapis:master Jan 8, 2015
@dhermes dhermes deleted the allow-get-single-key branch January 8, 2015 23:10
@dhermes dhermes mentioned this pull request Jan 14, 2015
Closed
8 tasks
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Aug 15, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#521)
87fc59d 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow to v2.14.0 (#521)
21338af
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
feat: add support for new Dataproc features (#521)
878a49c 
* feat: add support for new Dataproc features

PiperOrigin-RevId: 510421528

Source-Link: googleapis/googleapis@5a395e4

Source-Link: googleapis/googleapis-gen@54e9de1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTRlOWRlMWYxM2RiZTBjNmJlZjViYzZlN2EyYTRlZGJkNTg4YmQxYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 3.12.3 (#521)
709b3d2 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
chore(python): drop flake8-import-order in samples noxfile (#521)
19a5ea2 
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
feat: Add support for python 3.11 (#521)
20fc784 
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* require proto-plus 1.22.2 for python 3.11; workaround docs issue

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#521)
274a7cf 
Source-Link: googleapis/synthtool@5f2a608
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: store artifacts in placer (#521)
0401b06 
Source-Link: googleapis/synthtool@cb96037
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
@renovate-bot
chore(deps): update all dependencies (#521)
12aa1d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @coveralls @tseaver