Adding umbrella datastore.set_defaults(). #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be the most common auth / setup path for typical users.
|
Incremental change LGTM. I worry a little that we have gradually hidden from view how to set up the environment in non-magic cases to allow the defaults to Just Work(TM). |
|
Yes it's a delicate balance to strike and by no means do I think I have it fully figured out. I want to make it easy for the typical user, which will have only one credential and one dataset ID to worry about and won't want to deal with the rest of the mess that comes with. |
dhermes
added a commit
that referenced
this pull request
Jan 12, 2015
Adding umbrella datastore.set_defaults().
parthea
pushed a commit
that referenced
this pull request
Aug 15, 2023
) * feat: added include_bigquery_export_settings to ExportAgentRequest feat: added session_ttl to SessionProto PiperOrigin-RevId: 541038902 Source-Link: googleapis/googleapis@f472565 Source-Link: googleapis/googleapis-gen@a91bf45 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTkxYmY0NTI3ZGQ4NmE4NjhhODIyMGIyZDgxNTVlZWFlYzU5NzcwOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: added include_bigquery_export_settings to ExportAgentRequest feat: added session_ttl to SessionProto PiperOrigin-RevId: 541070954 Source-Link: googleapis/googleapis@439d4ee Source-Link: googleapis/googleapis-gen@ad5c4d3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWQ1YzRkM2YyNmJmOWJkMTY4ZTg2MzQyOGRkYTBiODgyOTM5MTYyOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* chore: Update gapic-generator-python to v1.8.5 PiperOrigin-RevId: 511892190 Source-Link: googleapis/googleapis@a45d9c0 Source-Link: googleapis/googleapis-gen@1907294 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be the most common auth / setup path for typical users.
It may make sense at some point to create a config class in
datastore/_implicit_environ.pyto allow lots of config at once / swappable setting for multi-tenant applications.