Limiting Bucket.make_public(recursive=True). #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying the same limit for number of blobs to iterate through that Bucket.delete(force=True) has.
|
LGTM. BTW, what happened to coveralls.io? |
dhermes
added a commit
that referenced
this pull request
May 14, 2015
Limiting Bucket.make_public(recursive=True).
|
Good catch on coveralls. The output in Travis says: This means we need to pass through the |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
May 14, 2015
See googleapis#878 for context.
|
Thanks guys, you save my day. I encountered the same issue with coveralls. |
|
w00t It ( |
dhermes
added a commit
to dhermes/oauth2client
that referenced
this pull request
May 14, 2015
See googleapis#176 and googleapis/google-cloud-python#878 for context.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
May 14, 2015
Caused by googleapis#878 and googleapis#879 passing by each other simultaneously.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
May 14, 2015
See googleapis#878 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the same limit for number of blobs to iterate through
that Bucket.delete(force=True) has.