Skip to content

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented May 26, 2015

Makes distinction between an iterable of keys and a single
key for get requests and re-purposes the get() name for the
single key case.

Fixes #701.

Makes distinction between an iterable of keys and a single
key for get requests and re-purposes the get() name for the
single key case.

Fixes googleapis#701.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label May 26, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2015
@jgeewax
Copy link
Contributor

jgeewax commented May 26, 2015

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d345186 on dhermes:fix-701-2nd-attempt into 6cf0852 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented May 26, 2015

@tseaver Care to weigh in?

@tseaver
Copy link
Contributor

tseaver commented May 26, 2015

Sorry -- I figured since I asked for it an @jgeewax OK'ed it, you were good to go. LGTM.

dhermes added a commit that referenced this pull request May 26, 2015
Implementing get_multi in datastore.
@dhermes dhermes merged commit 4dd4415 into googleapis:master May 26, 2015
@dhermes
Copy link
Contributor Author

dhermes commented May 26, 2015

@tseaver No worries. It wasn't pressing and I wanted to give you a chance to weigh in if you had any thoughts.

@dhermes dhermes deleted the fix-701-2nd-attempt branch May 26, 2015 18:48
parthea pushed a commit that referenced this pull request Aug 21, 2025
Source-Link: googleapis/synthtool@aa69fb7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datastore.get() requires a list
5 participants