fix(videointelligence): make features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth)
#9440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…API or client library generator.
features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth)
busunkim96
reviewed
Oct 10, 2019
videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py
Show resolved
Hide resolved
|
@busunkim96 Making |
features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth)features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth)
|
Artman is creating a failing unit test here, |
busunkim96
reviewed
Oct 10, 2019
videointelligence/tests/unit/gapic/v1/test_video_intelligence_service_client_v1.py
Show resolved
Hide resolved
features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth)features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth)
busunkim96
approved these changes
Oct 28, 2019
busunkim96
added a commit
to busunkim96/google-cloud-python
that referenced
this pull request
Nov 14, 2019
…r in `annotate_video`, update retry config, make AnnotateVideo nonidempotent (via synth) (googleapis#9440)" This reverts commit 9fd07ec.
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…notate_video`, update retry config, make AnnotateVideo nonidempotent (via synth) (#9440)
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…eter (#9810) * Makes `features` a keyword parameter to annotate_video This reverts part of commit 853d6125082589fe3bf8a3f5b347507de73589da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: