Rename 'dataset.Dataset' -> 'client.Client'. #946
Merged
+90
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
LGTM with emphasis on m == ME @jgeewax May have a preference here. |
|
OK so sample code would read something like... client = datastore.Client(dataset_id='whatever')
client.get(<key here>)? If so, then huge +1. |
|
It is still in work (I have the ordering / break-up somewhat wrong in #944). |
tseaver
added a commit
that referenced
this pull request
Jun 25, 2015
Rename 'dataset.Dataset' -> 'client.Client'.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Jun 25, 2015
See googleapis#946 for context.
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
* fix: separate create_stream() in pyarrow sample * remove append_rows() * lint * add blank row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #944.