Skip to content

feat(storage): add UBLA attrs to IAMConfiguration #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2019
Merged

feat(storage): add UBLA attrs to IAMConfiguration #9475

merged 4 commits into from
Oct 31, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 15, 2019 •
edited
Loading

Deprecate passing / setting BPO.

Supersedes #9021.

Closes #8552.

@tseaver
feat(storage): add UBLA attrs to IAMConfiguration
3b4a567 
Deprecate passing / setting BPO.

Supersedes #9021.
@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Oct 15, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2019
@tseaver
test: update systests to use UBLA.
8e36bad 
Remove skipped test, because backend fix is live.
@tseaver tseaver mentioned this pull request Oct 15, 2019
Closed
4 tasks
@tseaver tseaver mentioned this pull request Oct 22, 2019
Closed
JesseLovelace
JesseLovelace requested changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@JesseLovelace JesseLovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one typo

@tseaver tseaver requested a review from JesseLovelace October 29, 2019 18:43
@tseaver
Copy link
Contributor Author

tseaver commented Oct 29, 2019

@JesseLovelace I just heard from @quartzmo that you asked him to hold off on merging his UBLA PR for Ruby. Does this PR need to wait as well? We don't actually link to the back-end docs for either BPO or UBLA.

JesseLovelace
JesseLovelace reviewed Oct 29, 2019
View reviewed changes
JesseLovelace
JesseLovelace reviewed Oct 29, 2019
View reviewed changes
JesseLovelace
JesseLovelace reviewed Oct 29, 2019
View reviewed changes
JesseLovelace
JesseLovelace reviewed Oct 29, 2019
View reviewed changes
@tseaver tseaver requested a review from JesseLovelace October 30, 2019 17:18
@JesseLovelace
Copy link
Contributor

Thanks for working on this @tseaver, this can be merged

@tseaver tseaver merged commit cdcc278 into googleapis:master Oct 31, 2019
@tseaver tseaver deleted the 9021-storage-add-uniform-bucket-level-access branch October 31, 2019 15:46
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseLovelace JesseLovelace JesseLovelace approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: 'test_bpo_set_unset_preserves_acls' no longer sees expected 'BadRequest'.
3 participants
@tseaver @JesseLovelace @googlebot