Skip to content

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Oct 26, 2019

This PR was generated using Autosynth. 🌈

Summary of changes:

  • Add monitoring.v3.InternalChecker.state
  • Add monitoring.v3.UptimeCheckConfig.ContentMatcher.ContentMatcherOption
  • Add recursive parameter to delete_group
  • Add read-only validity field to monitoring.v3.AlertPolicy
  • Add validate_ssl parameter to monitoring.v3.UptimeCheckConfig.HttpCheck

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/monitoring/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:c805f50525f5f557886c94ab76f56eaa09cb1da58c3ee95111fd34259376621a
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/monitoring/artman_monitoring.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/group_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/group_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/metric.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/metric.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/alert_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/alert_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/dropped_labels.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/dropped_labels.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/group.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/group.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/common.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/common.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/notification.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/notification.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/metric_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/metric_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/alert.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/alert.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/uptime_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/uptime_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/mutation_record.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/mutation_record.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/uptime.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/uptime.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/span_context.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/span_context.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/monitoring/v3/notification_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto/notification_service.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3/google/cloud/monitoring_v3/proto.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/metric_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/uptime_check_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/notification_channel_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/group_service_client.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/monitoring_v3/proto/common_pb2.py.
synthtool > No replacements made in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py for pattern then a new `\[CONDITION_ID\]` is created.
, maybe replacement is not longer needed?
synthtool > Replaced '                ::\n\n' in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py.
synthtool > Replaced '^(\\s+)have an ``id`` label:  ::      resource.type =\n.*' in google/cloud/monitoring_v3/proto/metric_service_pb2.py.
synthtool > Replaced 'from google.cloud.monitoring_v3.gapic import notification_channel_service_client\n' in google/cloud/monitoring_v3/__init__.py.
synthtool > Replaced 'notification_channel_service_client.NotificationChannelServiceClient' in google/cloud/monitoring_v3/__init__.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/alert_policy_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/docs/conf.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/group_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/metric_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/alert_policy_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/notification_channel_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/group_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/alert_policy_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/group_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/metric_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/uptime_check_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/transports/notification_channel_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/metric_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/uptime_check_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/alert_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/notification_channel_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/alert_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/gapic/uptime_check_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/common_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/dropped_labels_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/dropped_labels_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/alert_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/group_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/group_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/group_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/common_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/metric_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/alert_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/metric_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/mutation_record_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/mutation_record_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/metric_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/notification_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/group_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/notification_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/notification_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/span_context_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/span_context_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/uptime_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/metric_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/notification_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/uptime_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/uptime_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/system/gapic/v3/test_system_metric_service_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_alert_policy_service_client_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_group_service_client_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/google/cloud/monitoring_v3/proto/uptime_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_uptime_check_service_client_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_metric_service_client_v3.py
reformatted /tmpfs/src/git/autosynth/working_repo/monitoring/tests/unit/gapic/v3/test_notification_channel_service_client_v3.py
All done! ✨ 🍰 ✨
56 files reformatted, 9 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: monitoring Issues related to the Cloud Monitoring API. label Oct 26, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2019
@tseaver
Copy link
Contributor

tseaver commented Oct 29, 2019

@busunkim96 This is once again hard to evaluate without any context for the change to the protos.

@@ -397,6 +397,31 @@ class ConditionCombinerType(enum.IntEnum):
AND_WITH_MATCHING_RESOURCE = 3


class InternalChecker(object):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add internal checker

@@ -498,3 +523,33 @@ class VerificationStatus(enum.IntEnum):
VERIFICATION_STATUS_UNSPECIFIED = 0
UNVERIFIED = 1
VERIFIED = 2


class UptimeCheckConfig(object):
Copy link
Contributor

@busunkim96 busunkim96 Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add monitoring.v3.UptimeCheckConfig.ContentMatcher.ContentMatcherOption

@@ -618,6 +619,9 @@ def delete_group(
Args:
name (str): The group to delete. The format is
``"projects/{project_id_or_number}/groups/{group_id}"``.
recursive (bool): If this field is true, then the request means to delete a group with all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add recursive option to delete_group

necessary the same as the workspace project.
The GCP project ID where the internal checker lives. Not
necessary the same as the Workspace project.
state:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add state to monitoring.v3.InternalChcker

@@ -1222,6 +1234,10 @@
if it has not been populated. The field should always be
populated on List and Get operations, unless a field
projection has been specified that strips it out.
validity:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add read-only validity field to monitoring.v3.AlertPolicy

@@ -1136,6 +1274,12 @@
Entering two separate headers with the same key in a Create
call will cause the first to be overwritten by the second. The
maximum number of headers allowed is 100.
validate_ssl:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add validate_ssl parameter to monitoring.v3.UptimeCheckConfig.HttpCheck

@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated monitoring to pick up changes in the API or client library generator. feat(monitoring): add monitoring.v3.InternalChecker.state; add monitoring.v3.UptimeCheckConfig.ContentMatcher.ContentMatcherOption; add recursive parameter to delete_group; add read-only validity field to monitoring.v3.AlertPolicy; add validate_ssl parameter to monitoring.v3.UptimeCheckConfig.HttpCheck Nov 13, 2019
@busunkim96 busunkim96 merged commit aef2210 into master Nov 13, 2019
parthea pushed a commit that referenced this pull request Oct 21, 2023
…itoring.v3.UptimeCheckConfig.ContentMatcher.ContentMatcherOption`; add `recursive` parameter to `delete_group`; add read-only `validity` field to `monitoring.v3.AlertPolicy`; add `validate_ssl` parameter to `monitoring.v3.UptimeCheckConfig.HttpCheck` (#9546)

* Add `monitoring.v3.InternalChecker.state`
* Add `monitoring.v3.UptimeCheckConfig.ContentMatcher.ContentMatcherOption`
* Add `recursive` parameter to `delete_group`
* Add read-only `validity` field to `monitoring.v3.AlertPolicy`
* Add `validate_ssl` parameter to `monitoring.v3.UptimeCheckConfig.HttpCheck`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants