Skip to content

tests(storage): fix query-string order dependent assert #9728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 11, 2019
Merged

tests(storage): fix query-string order dependent assert #9728

merged 5 commits into from
Nov 11, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 11, 2019

Note to reviewers: commit-by-commit will make the cleanups / refactorings clearer.

Closes #9714.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. testing labels Nov 11, 2019
@tseaver tseaver requested a review from frankyn as a code owner November 11, 2019 20:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2019
frankyn
frankyn approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tseaver

@tseaver tseaver merged commit ce04e30 into googleapis:master Nov 11, 2019
@tseaver tseaver deleted the 9714-storage-fix-qs-order-dependent-assert branch November 11, 2019 21:07
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@busunkim96 busunkim96 Awaiting requested review from busunkim96

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: query string order dependency in 'test_create_bucket_with_string_confict' unit test.
3 participants
@tseaver @frankyn @googlebot